[
https://issues.apache.org/jira/browse/DRILL-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286859#comment-15286859
]
ASF GitHub Bot commented on DRILL-4654:
---------------------------------------
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/495#discussion_r63546312
--- Diff:
common/src/main/java/org/apache/drill/exec/util/SystemPropertyUtil.java ---
@@ -0,0 +1,189 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.util;
+
+import java.security.AccessController;
+import java.security.PrivilegedAction;
+import java.util.regex.Pattern;
+
+/**
+ * A collection of utility methods to retrieve and parse the values of
Java system properties.
+ *
+ * This is a modified version of Netty's internal system property utility
class.
--- End diff --
What is the motivation behind re-implementing this utility class ? I'm too
lazy to check what's the difference between netty's implementation and this one
=P
> Expose New System Metrics
> -------------------------
>
> Key: DRILL-4654
> URL: https://issues.apache.org/jira/browse/DRILL-4654
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Sudheesh Katkam
> Assignee: Sudheesh Katkam
> Fix For: 1.8.0
>
>
> + Add more metrics to the DrillMetrics registry (exposed through web UI and
> jconsole, through JMX): pending queries, running queries, completed queries,
> current memory usage (root allocator)
> + Clean up and document metric registration API
> + Deprecate getMetrics() method in contextual objects; use
> DrillMetrics.getRegistry() directly
> + Make JMX reporting and log reporting configurable through system properties
> (since config file is not meant to be used in common module)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
