[
https://issues.apache.org/jira/browse/DRILL-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272693#comment-15272693
]
ASF GitHub Bot commented on DRILL-4654:
---------------------------------------
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/495#issuecomment-217221522
Good points. I added a comment in code, but it does not completely address
your concerns.
Unfortunately, not all class (e.g. RootAllocator) can be instrumented for
metrics if the single instance is part of a contextual object. Static instance
is fine according to [library
doc](https://dropwizard.github.io/metrics/3.1.0/getting-started/#the-registry).
This means maintaining state in a static object. Is there a workaround?
AFAIK we do not provide a way to run multiple drillbits in the same JVM in
production use cases. You are right, metrics will conflict for unit tests (as
is, right now).
> Expose New System Metrics
> -------------------------
>
> Key: DRILL-4654
> URL: https://issues.apache.org/jira/browse/DRILL-4654
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Sudheesh Katkam
> Assignee: Sudheesh Katkam
> Fix For: 1.8.0
>
>
> + Add more metrics to the DrillMetrics registry (exposed through web UI and
> jconsole, through JMX): pending queries, running queries, completed queries,
> current memory usage (root allocator)
> + Clean up and document metric registration API
> + Deprecate getMetrics() method in contextual objects; use
> DrillMetrics.getRegistry() directly
> + Make JMX reporting and log reporting configurable through system properties
> (since config file is not meant to be used in common module)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
