[
https://issues.apache.org/jira/browse/DRILL-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863182#comment-15863182
]
ASF GitHub Bot commented on DRILL-5257:
---------------------------------------
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/747
DRILL-5257: Boot-time control of query profiles
Adds a boot-time option to save query profiles before final query
response, after, or not at all.
Tests for normal “async” case are normal unit tests. Tests for “sync”
case are unit tests using the new framework that parse profiles.
See DRILL-5257 JIRA for details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/747.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #747
----
commit 36d489ded584ba4fa8460de910bf834b508ccfbb
Author: Paul Rogers <[email protected]>
Date: 2017-02-13T03:50:35Z
Boot-time control of query profiles
Adds a boot-time option to save query profiles before final query
response, after, or not at all.
Tests for normal “async” case are normal unit tests. Tests for “sync”
case are unit tests using the new framework that parse profiles.
----
> Provide option to save query profiles sync, async or not at all
> ---------------------------------------------------------------
>
> Key: DRILL-5257
> URL: https://issues.apache.org/jira/browse/DRILL-5257
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.10
>
>
> DRILL-5123 improved perceived query performance by writing the query profile
> after sending a final response to the client. This is the desired behaviors
> in most situations. However, some tests want to verify certain results by
> reading the query profile from disk. Doing so works best when the query
> profile is written before returning the final query results.
> This ticket requests that the timing if the query profile writing be
> configurable.
> * Sync: write profile before final client response.
> * Async: write profile after final client response. (Default)
> * None: don't write query profile at all
> A config option (boot time? run time?) should control the option. A boot-time
> option is fine for testing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
