[
https://issues.apache.org/jira/browse/DRILL-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877414#comment-15877414
]
ASF GitHub Bot commented on DRILL-5257:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/747#discussion_r102377957
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -853,7 +875,9 @@ public void close() throws Exception {
// storage write; query completion occurs in parallel with profile
// persistence.
- queryManager.writeFinalProfile(uex);
+ if (profileOption == ProfileOption.ASYNC) {
+ writeProfile(uex);
--- End diff --
I dislike redundant code, but sure, it's just one line, I can paste it
twice.
> Provide option to save query profiles sync, async or not at all
> ---------------------------------------------------------------
>
> Key: DRILL-5257
> URL: https://issues.apache.org/jira/browse/DRILL-5257
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.10
>
>
> DRILL-5123 improved perceived query performance by writing the query profile
> after sending a final response to the client. This is the desired behaviors
> in most situations. However, some tests want to verify certain results by
> reading the query profile from disk. Doing so works best when the query
> profile is written before returning the final query results.
> This ticket requests that the timing if the query profile writing be
> configurable.
> * Sync: write profile before final client response.
> * Async: write profile after final client response. (Default)
> * None: don't write query profile at all
> A config option (boot time? run time?) should control the option. A boot-time
> option is fine for testing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
