[
https://issues.apache.org/jira/browse/DRILL-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876434#comment-15876434
]
ASF GitHub Bot commented on DRILL-5257:
---------------------------------------
Github user ppadma commented on a diff in the pull request:
https://github.com/apache/drill/pull/747#discussion_r102277543
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -413,4 +413,19 @@
String DYNAMIC_UDF_SUPPORT_ENABLED = "exec.udf.enable_dynamic_support";
BooleanValidator DYNAMIC_UDF_SUPPORT_ENABLED_VALIDATOR = new
BooleanValidator(DYNAMIC_UDF_SUPPORT_ENABLED, true, true);
+
+ /**
+ * Option to save query profiles.
+ * <ul>
+ * <li>async (default): Write query profile after last response
+ * to the client.</li>
+ * <li>sync: Write the query profile before the last response to
+ * the client. Very useful for testing to avoid race conditions.</li>
+ * <li>none: Don't write the query profile at all. Useful when running
+ * many production jobs that do not need to be reviewed.</li>
+ * </ul>
+ */
+ String QUERY_PROFILE_OPTION = "exec.profile";
--- End diff --
exec.query_profile.write_mode might be a better choice for clarity.
Also, would it be better to have two options ?
boolean: exec.query_profile.write_enabled and exec.query_profile.write_mode
(sync or async).
> Provide option to save query profiles sync, async or not at all
> ---------------------------------------------------------------
>
> Key: DRILL-5257
> URL: https://issues.apache.org/jira/browse/DRILL-5257
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.10
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.10
>
>
> DRILL-5123 improved perceived query performance by writing the query profile
> after sending a final response to the client. This is the desired behaviors
> in most situations. However, some tests want to verify certain results by
> reading the query profile from disk. Doing so works best when the query
> profile is written before returning the final query results.
> This ticket requests that the timing if the query profile writing be
> configurable.
> * Sync: write profile before final client response.
> * Async: write profile after final client response. (Default)
> * None: don't write query profile at all
> A config option (boot time? run time?) should control the option. A boot-time
> option is fine for testing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
