[ 
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210160#comment-16210160
 ] 

ASF GitHub Bot commented on DRILL-5783:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/984#discussion_r145294641
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBugFixes.java 
---
    @@ -33,8 +35,11 @@
     @Category(UnlikelyTest.class)
     public class TestBugFixes extends BaseTestQuery {
       private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(TestBugFixes.class);
    -  private static final String WORKING_PATH = TestTools.getWorkingPath();
    -  private static final String TEST_RES_PATH = WORKING_PATH + 
"/src/test/resources";
    +
    +  @BeforeClass
    +  public static void setupTestFiles() {
    +    dirTestWatcher.copyResourceToRoot("/bugs/DRILL-4192");
    --- End diff --
    
    Small nit. Presumably `/bugs/DRILL-4192` is a relative path. Should we 
express it in the normal Unix fashion as `bugs/DRILL-4192`? That way, in 
time-honored fashion, a leading slash tells us the path is absolute.


> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
>                 Key: DRILL-5783
>                 URL: https://issues.apache.org/jira/browse/DRILL-5783
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to