[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210161#comment-16210161
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145293197
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAggNullable.java ---
@@ -61,10 +57,8 @@ public void testHashAggNullableColumns() throws
Exception {
@Test // StreamingAgg on nullable columns
public void testStreamAggNullableColumns() throws Exception {
- String query1 = String.format("select t2.b2 from
dfs_test.`%s/jsoninput/nullable2.json` t2 " +
- " group by t2.b2", TEST_RES_PATH);
- String query2 = String.format("select t2.a2, t2.b2 from
dfs_test.`%s/jsoninput/nullable2.json` t2 " +
- " group by t2.a2, t2.b2", TEST_RES_PATH);
+ String query1 = "select t2.b2 from cp.`/jsoninput/nullable2.json` t2
group by t2.b2";
+ String query2 = "select t2.a2, t2.b2 from
cp.`/jsoninput/nullable2.json` t2 group by t2.a2, t2.b2";
--- End diff --
Very nice improvement; this has been bugging me for months. Why doctor up
the query string when we have perfectly fine workspace mechanism.
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
