[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210154#comment-16210154
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r144943191
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java ---
@@ -90,12 +89,11 @@
private String generatedCode;
private String generifiedCode;
- CodeGenerator(TemplateClassDefinition<T> definition,
FunctionImplementationRegistry funcRegistry, OptionSet optionManager) {
- this(ClassGenerator.getDefaultMapping(), definition, funcRegistry,
optionManager);
+ CodeGenerator(TemplateClassDefinition<T> definition, OptionSet
optionManager) {
+ this(ClassGenerator.getDefaultMapping(), definition, optionManager);
--- End diff --
Good analysis. It was a real pain to lug the function registry around.
Presumably the registry is used elsewhere in code gen; perhaps in the
expression materializer.
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
