[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210169#comment-16210169
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145505524
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestCorruptParquetDateCorrection.java
---
@@ -76,43 +78,50 @@
// - detecting corrupt values must be deferred to actual data
page reading
// - one from 1.4, where there is a proper created-by, but the
corruption is present
private static final String MIXED_CORRUPTED_AND_CORRECT_DATES_PATH =
-
"[WORKING_PATH]/src/test/resources/parquet/4203_corrupt_dates/mixed_drill_versions";
+ "/parquet/4203_corrupt_dates/mixed_drill_versions";
// partitioned with 1.2.0, no certain metadata that these were written
with Drill
// the value will be checked to see that they look corrupt and they will
be corrected
// by default. Users can use the format plugin option
autoCorrectCorruptDates to disable
// this behavior if they have foreign parquet files with valid rare date
values that are
// in the similar range as Drill's corrupt values
+ private static final String PARTITIONED_1_2_FOLDER =
"partitioned_with_corruption_4203_1_2";
private static final String CORRUPTED_PARTITIONED_DATES_1_2_PATH =
-
"[WORKING_PATH]/src/test/resources/parquet/4203_corrupt_dates/partitioned_with_corruption_4203_1_2";
+ Paths.get("/parquet/4203_corrupt_dates",
PARTITIONED_1_2_FOLDER).toString();
--- End diff --
Again, do we want an absolute-looking path when we actually have a relative
path?
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
