[
https://issues.apache.org/jira/browse/DRILL-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303834#comment-16303834
]
ASF GitHub Bot commented on DRILL-5971:
---------------------------------------
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1049#discussion_r158700125
--- Diff: exec/vector/src/main/codegen/templates/FixedValueVectors.java ---
@@ -394,9 +394,11 @@ public void get(int index,
Nullable${minor.class}Holder holder){
final int offsetIndex = index * VALUE_WIDTH;
final int months = data.getInt(offsetIndex);
final int days = data.getInt(offsetIndex + ${minor.daysOffset});
- final int millis = data.getInt(offsetIndex +
${minor.millisecondsOffset});
+ int millis = data.getInt(offsetIndex + 8);
--- End diff --
I think we should revert this change. It is easier to change `daysOffset`
and `millisecondsOffset` values in `ValueVectorTypes.tdd` rather find all
usages if it will be needed.
> Fix INT64, INT32 logical types in complex parquet reader
> --------------------------------------------------------
>
> Key: DRILL-5971
> URL: https://issues.apache.org/jira/browse/DRILL-5971
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.11.0
> Reporter: Parth Chandra
> Assignee: Parth Chandra
> Fix For: 1.13.0
>
>
> The 'complex' Parquet reader does not recognize the Parquet logical types
> INT64, and INT32.
> Should be a simple change to add these logical types.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
