[ 
https://issues.apache.org/jira/browse/DRILL-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303836#comment-16303836
 ] 

ASF GitHub Bot commented on DRILL-5971:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1049#discussion_r158702957
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
 ---
    @@ -636,8 +636,10 @@ public void testCTASWithIntervalTypes() throws 
Exception {
             "interval '-1000000000 20:12:23.999' day(10) to second col2 " +
             "from cp.`employee.json` limit 2", tableName);
     
    -    Period row1Col1 = new Period(0, 0, 0, 10, 0, 0, 0, 73840123);
    -    Period row1Col2 = new Period(0, 0, 0, -1000000000, 0, 0, 0, -72743999);
    +//    Period row1Col1 = new Period(0, 0, 0, 10, 0, 0, 0, 73840123);
    +//    Period row1Col2 = new Period(0, 0, 0, -1000000000, 0, 0, 0, 
-72743999);
    --- End diff --
    
    Please remove these comment lines.


> Fix INT64, INT32 logical types in complex parquet reader
> --------------------------------------------------------
>
>                 Key: DRILL-5971
>                 URL: https://issues.apache.org/jira/browse/DRILL-5971
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Parth Chandra
>            Assignee: Parth Chandra
>             Fix For: 1.13.0
>
>
> The 'complex' Parquet reader does not recognize the Parquet logical types 
> INT64, and INT32. 
> Should be a simple change to add these logical types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to