[
https://issues.apache.org/jira/browse/DRILL-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305818#comment-16305818
]
ASF GitHub Bot commented on DRILL-5971:
---------------------------------------
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1049#discussion_r158985937
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java
---
@@ -138,6 +138,8 @@
return new
ParquetFixedWidthDictionaryReaders.DictionaryBigIntReader(recordReader,
allocateSize, descriptor, columnChunkMetaData, fixedLength, (BigIntVector) v,
schemaElement);
--- End diff --
Hmm. Looks like I missed INT_32 here. Added it but I cannot seem to force
the test generator to generate dictionary encoded values for the logical int
types. I'll make a note to enhance it later. Note that the DATE type is
(apparently) handled by the code on line 101.
> Fix INT64, INT32 logical types in complex parquet reader
> --------------------------------------------------------
>
> Key: DRILL-5971
> URL: https://issues.apache.org/jira/browse/DRILL-5971
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.11.0
> Reporter: Parth Chandra
> Assignee: Parth Chandra
> Fix For: 1.13.0
>
>
> The 'complex' Parquet reader does not recognize the Parquet logical types
> INT64, and INT32.
> Should be a simple change to add these logical types.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
