[ 
https://issues.apache.org/jira/browse/DRILL-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416567#comment-16416567
 ] 

ASF GitHub Bot commented on DRILL-6284:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1181#discussion_r177617922
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatchMemoryManager.java
 ---
    @@ -29,6 +29,50 @@
       private int outgoingRowWidth;
       private RecordBatchSizer sizer;
     
    +  /**
    +   * operator metric stats
    +   */
    +  private long numIncomingBatches;
    +  private long sumInputBatchSizes;
    +  private long sumInputRowWidths;
    +  private long totalInputRecords;
    +  private long numOutgoingBatches;
    +  private long sumOutputBatchSizes;
    +  private long sumOutputRowWidths;
    +  private long totalOutputRecords;
    +
    +  public long getNumIncomingBatches() {
    +    return numIncomingBatches;
    +  }
    +
    +  public long getTotalInputRecords() {
    +    return totalInputRecords;
    +  }
    +
    +  public long getNumOutgoingBatches() {
    +    return numOutgoingBatches;
    +  }
    +
    +  public long getTotalOutputRecords() {
    +    return totalOutputRecords;
    +  }
    +
    +  public long getAvgInputBatchSize() {
    +    return RecordBatchSizer.safeDivide(sumInputBatchSizes, 
numIncomingBatches);
    +  }
    +
    +  public long getAvgInputRowWidth() {
    +    return RecordBatchSizer.safeDivide(sumInputRowWidths, 
numIncomingBatches);
    --- End diff --
    
    See below regarding the average calculation.


> Add operator metrics for batch sizing for flatten
> -------------------------------------------------
>
>                 Key: DRILL-6284
>                 URL: https://issues.apache.org/jira/browse/DRILL-6284
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>    Affects Versions: 1.13.0
>            Reporter: Padma Penumarthy
>            Assignee: Padma Penumarthy
>            Priority: Critical
>             Fix For: 1.14.0
>
>
> Add the following operator metrics for flatten.
> NUM_INCOMING_BATCHES,
> AVG_INPUT_BATCH_SIZE,
> AVG_INPUT_ROW_WIDTH,
> TOTAL_INPUT_RECORDS,
> NUM_OUTGOING_BATCHES,
> AVG_OUTPUT_BATCH_SIZE,
> AVG_OUTPUT_ROW_WIDTH,
> TOTAL_OUTPUT_RECORDS;
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to