[
https://issues.apache.org/jira/browse/DRILL-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421536#comment-16421536
]
ASF GitHub Bot commented on DRILL-6284:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1181#discussion_r178445244
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
---
@@ -127,17 +153,20 @@
@Override
public void update(int inputIndex) {
switch(inputIndex) {
- case 0:
- leftSizer = new RecordBatchSizer(left);
- leftRowWidth = leftSizer.netRowWidth();
+ case LEFT_INDEX:
+ setRecordBatchSizer(inputIndex, new RecordBatchSizer(left));
+ leftRowWidth = getRecordBatchSizer(inputIndex).netRowWidth();
+ logger.debug("mergejoin left incoming batch sizer : {}",
getRecordBatchSizer(inputIndex));
--- End diff --
Maybe "Left incoming batch size"? (The log will tell you it is the merge
join. The "sizer" is an implementation detail.)
> Add operator metrics for batch sizing for flatten
> -------------------------------------------------
>
> Key: DRILL-6284
> URL: https://issues.apache.org/jira/browse/DRILL-6284
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Critical
> Fix For: 1.14.0
>
>
> Add the following operator metrics for flatten.
> NUM_INCOMING_BATCHES,
> AVG_INPUT_BATCH_SIZE,
> AVG_INPUT_ROW_WIDTH,
> TOTAL_INPUT_RECORDS,
> NUM_OUTGOING_BATCHES,
> AVG_OUTPUT_BATCH_SIZE,
> AVG_OUTPUT_ROW_WIDTH,
> TOTAL_OUTPUT_RECORDS;
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
