[
https://issues.apache.org/jira/browse/DRILL-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421537#comment-16421537
]
ASF GitHub Bot commented on DRILL-6284:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1181#discussion_r178445262
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
---
@@ -153,16 +182,22 @@ public void update(int inputIndex) {
// calculate memory used so far based on previous outgoing row width
and how many rows we already processed.
final long memoryUsed = status.getOutPosition() *
getOutgoingRowWidth();
// This is the remaining memory.
- final long remainingMemory =
Math.max(outputBatchSize/WORST_CASE_FRAGMENTATION_FACTOR - memoryUsed, 0);
+ final long remainingMemory = Math.max(outputBatchSize - memoryUsed,
0);
// These are number of rows we can fit in remaining memory based on
new outgoing row width.
final int numOutputRowsRemaining =
RecordBatchSizer.safeDivide(remainingMemory, newOutgoingRowWidth);
- status.setTargetOutputRowCount(status.getOutPosition() +
numOutputRowsRemaining);
+
status.setTargetOutputRowCount(adjustOutputRowCount(status.getOutPosition() +
numOutputRowsRemaining));
setOutgoingRowWidth(newOutgoingRowWidth);
+
+ logger.debug("outputBatchSize : {}, avgOutgoingRowWidth : {},
outputRowCount : {}",
--- End diff --
Since this is a label, not a symbol, maybe "output batch size: {}"
> Add operator metrics for batch sizing for flatten
> -------------------------------------------------
>
> Key: DRILL-6284
> URL: https://issues.apache.org/jira/browse/DRILL-6284
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Critical
> Fix For: 1.14.0
>
>
> Add the following operator metrics for flatten.
> NUM_INCOMING_BATCHES,
> AVG_INPUT_BATCH_SIZE,
> AVG_INPUT_ROW_WIDTH,
> TOTAL_INPUT_RECORDS,
> NUM_OUTGOING_BATCHES,
> AVG_OUTPUT_BATCH_SIZE,
> AVG_OUTPUT_ROW_WIDTH,
> TOTAL_OUTPUT_RECORDS;
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
