[
https://issues.apache.org/jira/browse/DRILL-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424988#comment-16424988
]
ASF GitHub Bot commented on DRILL-6202:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r179023466
--- Diff: src/main/resources/checkstyle-config.xml ---
@@ -30,10 +30,15 @@
<module name="NeedBraces"/>
+ <module name="IllegalCatch">
--- End diff --
Do we want to do this? Why are all these forbidden? `Throwable` was needed
by @Ben-Zvi in his very first Drill bug fix. `RuntimeException` is the root of
the unchecked exceptions beloved by Drill code and is used as a general
"something went wrong" placeholder.
These are all commented out, but still...
Finally, `IndexOutOfBoundsException` is a perfectly fine exception. Adding
this line is probably handy to catch all reference as part of this fix, but
probably not helpful as a general policy.
> Deprecate usage of IndexOutOfBoundsException to re-alloc vectors
> ----------------------------------------------------------------
>
> Key: DRILL-6202
> URL: https://issues.apache.org/jira/browse/DRILL-6202
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Major
> Fix For: 1.14.0
>
>
> As bounds checking may be enabled or disabled, using
> IndexOutOfBoundsException to resize vectors is unreliable. It works only when
> bounds checking is enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
