[ 
https://issues.apache.org/jira/browse/DRILL-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425933#comment-16425933
 ] 

ASF GitHub Bot commented on DRILL-6202:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1144#discussion_r179229891
  
    --- Diff: 
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/BaseScalarWriter.java
 ---
    @@ -211,7 +211,7 @@ protected boolean canExpand(int delta) {
     
       protected void overflowed() {
         if (listener == null) {
    -      throw new IndexOutOfBoundsException("Overflow not supported");
    +      throw new UnsupportedOperationException("Overflow not supported");
    --- End diff --
    
    I also considered `OversizedAllocationException` but IMO 
`UnsupportedOperationException` is a better fit.


> Deprecate usage of IndexOutOfBoundsException to re-alloc vectors
> ----------------------------------------------------------------
>
>                 Key: DRILL-6202
>                 URL: https://issues.apache.org/jira/browse/DRILL-6202
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>            Priority: Major
>             Fix For: 1.14.0
>
>
> As bounds checking may be enabled or disabled, using 
> IndexOutOfBoundsException to resize vectors is unreliable. It works only when 
> bounds checking is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to