[
https://issues.apache.org/jira/browse/DRILL-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424987#comment-16424987
]
ASF GitHub Bot commented on DRILL-6202:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1144#discussion_r179023675
--- Diff: src/main/resources/checkstyle-suppressions.xml ---
@@ -16,4 +16,13 @@
<!-- Checkstyle Suppressions for Apache Drill -->
<suppressions>
<suppress files="[\\/]generated-sources[\\/]"
checks="AvoidStarImport,NeedBraces"/>
+ <suppress checks="IllegalCatch"
--- End diff --
In ML this is called over-fitting: I think we're adding a bit too much
complexity for too little value. I can just see myself, in a couple of months,
tearing my hair out wondering why the build fails on some perfectly benign
construct...
Maybe explain this rule in a comment?
> Deprecate usage of IndexOutOfBoundsException to re-alloc vectors
> ----------------------------------------------------------------
>
> Key: DRILL-6202
> URL: https://issues.apache.org/jira/browse/DRILL-6202
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Major
> Fix For: 1.14.0
>
>
> As bounds checking may be enabled or disabled, using
> IndexOutOfBoundsException to resize vectors is unreliable. It works only when
> bounds checking is enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
