[ 
https://issues.apache.org/jira/browse/DRILL-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445911#comment-16445911
 ] 

ASF GitHub Bot commented on DRILL-3855:
---------------------------------------

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1226#discussion_r183091126
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
    @@ -178,6 +178,12 @@ public RuleSet getRules(OptimizerRulesContext context, 
Collection<StoragePlugin>
               PlannerPhase.getPhysicalRules(context),
               getStorageRules(context, plugins, this));
         }
    +  },
    +
    +  PRE_LOGICAL_PLANNING("Planning with Hep planner only for rules, which 
are failed for Volcano planner") {
    --- End diff --
    
    I thought about whether a separate group of rules is needed instead of 
adding it to existing group of HEP rules.  But I suppose it is ok to create the 
separate group with the expectation that once Calcite-1271 is fixed for Volcano 
planner, we have the option to remove this group.   Thinking more about 
this..filter pushdown past a union-all is cost-safe since union-all output rows 
is equal or greater than input rows.  (it is not cost-safe for pushdown past 
union-distinct).  


> Enable FilterSetOpTransposeRule, DrillProjectSetOpTransposeRule
> ---------------------------------------------------------------
>
>                 Key: DRILL-3855
>                 URL: https://issues.apache.org/jira/browse/DRILL-3855
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.13.0
>            Reporter: Sean Hsuan-Yi Chu
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 1.14.0
>
>
> Since the infinite planning issues (Calcite Volcano Planner: Calcite-900) 
> reported in DRILL-3257, FilterSetOpTransposeRule, 
> DrillProjectSetOpTransposeRule were disabled. After it can be resolved in 
> Calcite, we have to enable these two rules to lift the performance. 
> In addition, will update the plan validation in Unit test in response of the 
> newly enabled rules. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to