[
https://issues.apache.org/jira/browse/DRILL-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450038#comment-16450038
]
ASF GitHub Bot commented on DRILL-3855:
---------------------------------------
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183763991
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
@@ -178,6 +178,12 @@ public RuleSet getRules(OptimizerRulesContext context,
Collection<StoragePlugin>
PlannerPhase.getPhysicalRules(context),
getStorageRules(context, plugins, this));
}
+ },
+
+ PRE_LOGICAL_PLANNING("Planning with Hep planner only for rules, which
are failed for Volcano planner") {
--- End diff --
You are right, it is necessary to add these rules to Drill's
`staticRuleSet`, so then these setOpTranspose rules can cover more cases.
When it will be added to Volcano Planner we can think, whether to remove
`PlannerPhase.PRE_LOGICAL_PLANNING` or to leave it for more complete
`directory_pruning` or think to move `PlannerPhase.DIRECTORY_PRUNING` to
`staticRuleSet` for Volcano Planner too.
> Enable FilterSetOpTransposeRule, DrillProjectSetOpTransposeRule
> ---------------------------------------------------------------
>
> Key: DRILL-3855
> URL: https://issues.apache.org/jira/browse/DRILL-3855
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Affects Versions: 1.13.0
> Reporter: Sean Hsuan-Yi Chu
> Assignee: Vitalii Diravka
> Priority: Major
> Fix For: 1.14.0
>
>
> Since the infinite planning issues (Calcite Volcano Planner: Calcite-900)
> reported in DRILL-3257, FilterSetOpTransposeRule,
> DrillProjectSetOpTransposeRule were disabled. After it can be resolved in
> Calcite, we have to enable these two rules to lift the performance.
> In addition, will update the plan validation in Unit test in response of the
> newly enabled rules.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
