[
https://issues.apache.org/jira/browse/DRILL-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450036#comment-16450036
]
ASF GitHub Bot commented on DRILL-3855:
---------------------------------------
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1226#discussion_r183768380
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
---
@@ -634,10 +634,14 @@ public void testFilterPushDownOverUnionAll() throws
Exception {
+ "order by n_regionkey";
// Validate the plan
- final String[] expectedPlan = {".*Filter.*\n" +
- ".*UnionAll.*\n" +
- ".*Scan.*columns=\\[`n_regionkey`\\].*\n" +
- ".*Scan.*columns=\\[`r_regionkey`\\].*"};
+ final String[] expectedPlan = {"Sort.*\n" +
--- End diff --
Looks like there are no issues related to it. I have added additional test
case to verify it:
`select n_nationkey from (select n_nationkey, n_name, n_comment from
cp."tpch/nation.parquet" union all select r_regionkey, r_name, r_comment from
cp."tpch/region.parquet") where n_nationkey > 4;`
When filter is pushed down the result from right side of UNION will be
empty.
Generally speaking using UNION operator with empty data was resolved in
[DRILL-4185](https://issues.apache.org/jira/browse/DRILL-4185) and we have test
cases with empty data batches.
> Enable FilterSetOpTransposeRule, DrillProjectSetOpTransposeRule
> ---------------------------------------------------------------
>
> Key: DRILL-3855
> URL: https://issues.apache.org/jira/browse/DRILL-3855
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Affects Versions: 1.13.0
> Reporter: Sean Hsuan-Yi Chu
> Assignee: Vitalii Diravka
> Priority: Major
> Fix For: 1.14.0
>
>
> Since the infinite planning issues (Calcite Volcano Planner: Calcite-900)
> reported in DRILL-3257, FilterSetOpTransposeRule,
> DrillProjectSetOpTransposeRule were disabled. After it can be resolved in
> Calcite, we have to enable these two rules to lift the performance.
> In addition, will update the plan validation in Unit test in response of the
> newly enabled rules.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
