[
https://issues.apache.org/jira/browse/DRILL-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474618#comment-16474618
]
ASF GitHub Bot commented on DRILL-6410:
---------------------------------------
sachouche commented on a change in pull request #1257: DRILL-6410: Fixed memory
leak in flat Parquet reader
URL: https://github.com/apache/drill/pull/1257#discussion_r188058597
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
##########
@@ -297,11 +297,11 @@ private void waitForExecutionResult() throws
InterruptedException, ExecutionExce
while (asyncPageRead != null && !asyncPageRead.isEmpty()) {
try {
Future<Void> f = asyncPageRead.poll();
- if(!f.isDone() && !f.isCancelled()){
+ if(!f.isDone() && !f.isCancelled()) {
f.cancel(true);
- } else {
- f.get(1, TimeUnit.MILLISECONDS);
}
+ // The framework guarantees a blocking version of FutureTask
cancellation. At this time we are
Review comment:
@vrozov
I have looked at that fix but decided against it as I felt the same logic
could be achieved with a simpler implementation especially that the performance
penalty is only incurred during the cancellation process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Memory leak in Parquet Reader during cancellation
> -------------------------------------------------
>
> Key: DRILL-6410
> URL: https://issues.apache.org/jira/browse/DRILL-6410
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Parquet
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
>
> Occasionally, a memory leak is observed within the flat Parquet reader when
> query cancellation is invoked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
