[
https://issues.apache.org/jira/browse/DRILL-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474998#comment-16474998
]
ASF GitHub Bot commented on DRILL-6410:
---------------------------------------
parthchandra commented on a change in pull request #1257: DRILL-6410: Fixed
memory leak in flat Parquet reader
URL: https://github.com/apache/drill/pull/1257#discussion_r188122320
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
##########
@@ -297,11 +297,11 @@ private void waitForExecutionResult() throws
InterruptedException, ExecutionExce
while (asyncPageRead != null && !asyncPageRead.isEmpty()) {
try {
Future<Void> f = asyncPageRead.poll();
- if(!f.isDone() && !f.isCancelled()){
+ if(!f.isDone() && !f.isCancelled()) {
f.cancel(true);
- } else {
- f.get(1, TimeUnit.MILLISECONDS);
}
+ // The framework guarantees a blocking version of FutureTask
cancellation. At this time we are
Review comment:
My $0.02 is to tend towards what @vrozov is suggesting. It would be
preferable to have one reusable implementation that works for both use cases.
I don't know if @sachouche needs the localStats in PartitionTask, nor, as he
mentioned, do you want to pay a price for non cancellation paths.
Is it possible to come up with a unified approach here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Memory leak in Parquet Reader during cancellation
> -------------------------------------------------
>
> Key: DRILL-6410
> URL: https://issues.apache.org/jira/browse/DRILL-6410
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - Parquet
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
>
> Occasionally, a memory leak is observed within the flat Parquet reader when
> query cancellation is invoked.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
