[
https://issues.apache.org/jira/browse/DRILL-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16485761#comment-16485761
]
ASF GitHub Bot commented on DRILL-6356:
---------------------------------------
Ben-Zvi commented on a change in pull request #1255: DRILL-6356: batch sizing
for union all
URL: https://github.com/apache/drill/pull/1255#discussion_r190087363
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
##########
@@ -34,9 +35,32 @@
// state (IterOutcome) of the right input
protected IterOutcome rightUpstream = IterOutcome.NONE;
- // For now only used by Lateral and Merge Join
protected RecordBatchMemoryManager batchMemoryManager;
+ public final int numInputs = 2;
+ public static final int LEFT_INDEX = 0;
+ public static final int RIGHT_INDEX = 1;
+
+ public enum Metric implements MetricDef {
+ LEFT_INPUT_BATCH_COUNT,
+ LEFT_AVG_INPUT_BATCH_BYTES,
+ LEFT_AVG_INPUT_ROW_BYTES,
+ LEFT_INPUT_RECORD_COUNT,
+ RIGHT_INPUT_BATCH_COUNT,
+ RIGHT_AVG_INPUT_BATCH_BYTES,
+ RIGHT_AVG_INPUT_ROW_BYTES,
+ RIGHT_INPUT_RECORD_COUNT,
+ OUTPUT_BATCH_COUNT,
+ AVG_OUTPUT_BATCH_BYTES,
+ AVG_OUTPUT_ROW_BYTES,
+ OUTPUT_RECORD_COUNT;
Review comment:
(A repeat of a prior comment on the Hash Join) -- We may be overloading the
operator Metrics with low level information that has no value to customers. The
Metrics are visible in the web UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> batch sizing for union all
> --------------------------
>
> Key: DRILL-6356
> URL: https://issues.apache.org/jira/browse/DRILL-6356
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> batch sizing changes for union all operator
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
