[
https://issues.apache.org/jira/browse/DRILL-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486599#comment-16486599
]
ASF GitHub Bot commented on DRILL-6356:
---------------------------------------
Ben-Zvi commented on a change in pull request #1255: DRILL-6356: batch sizing
for union all
URL: https://github.com/apache/drill/pull/1255#discussion_r190104881
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
##########
@@ -331,23 +349,35 @@ public boolean hasNext() {
}
@Override
- public Pair<IterOutcome, RecordBatch> next() {
+ public Pair<IterOutcome, BatchStatusWrappper> next() {
while (!batchStatusStack.isEmpty()) {
BatchStatusWrappper topStatus = batchStatusStack.peek();
if (topStatus.prefetched) {
topStatus.prefetched = false;
- return Pair.of(topStatus.outcome, topStatus.batch);
+ batchMemoryManager.update(topStatus.batch, topStatus.inputIndex);
+ return Pair.of(topStatus.outcome, topStatus);
} else {
+
+ // If we have more records to process, just return the top batch.
+ if (topStatus.recordsProcessed < topStatus.totalRecordsToProcess) {
Review comment:
Following on that minor comment above: Here ```topStatus.remainingRecords()
> 0```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> batch sizing for union all
> --------------------------
>
> Key: DRILL-6356
> URL: https://issues.apache.org/jira/browse/DRILL-6356
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> batch sizing changes for union all operator
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
