[
https://issues.apache.org/jira/browse/DRILL-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486666#comment-16486666
]
ASF GitHub Bot commented on DRILL-6356:
---------------------------------------
ppadma commented on a change in pull request #1255: DRILL-6356: batch sizing
for union all
URL: https://github.com/apache/drill/pull/1255#discussion_r190116474
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
##########
@@ -142,19 +148,26 @@ public int getRecordCount() {
@SuppressWarnings("resource")
- private IterOutcome doWork(RecordBatch inputBatch, boolean newSchema) throws
ClassTransformationException, IOException, SchemaChangeException {
- Preconditions.checkArgument(inputBatch.getSchema().getFieldCount() ==
container.getSchema().getFieldCount(),
+ private IterOutcome doWork(BatchStatusWrappper batchStatus, boolean
newSchema) throws ClassTransformationException, IOException,
SchemaChangeException {
+ Preconditions.checkArgument(batchStatus.batch.getSchema().getFieldCount()
== container.getSchema().getFieldCount(),
"Input batch and output batch have different field counthas!");
if (newSchema) {
- createUnionAller(inputBatch);
+ createUnionAller(batchStatus.batch);
}
+ // Get number of records to include in the batch.
+ final int recordsToProcess =
Math.min(batchMemoryManager.getOutputRowCount(),
(batchStatus.totalRecordsToProcess - batchStatus.recordsProcessed));
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> batch sizing for union all
> --------------------------
>
> Key: DRILL-6356
> URL: https://issues.apache.org/jira/browse/DRILL-6356
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.13.0
> Reporter: Padma Penumarthy
> Assignee: Padma Penumarthy
> Priority: Major
> Fix For: 1.14.0
>
>
> batch sizing changes for union all operator
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
