[
https://issues.apache.org/jira/browse/DRILL-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527836#comment-16527836
]
ASF GitHub Bot commented on DRILL-6554:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor
code improvements in parquet statistics handling
URL: https://github.com/apache/drill/pull/1349#discussion_r199199005
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java
##########
@@ -113,39 +113,39 @@ public boolean canDrop(RangeExprEvaluator<C> evaluator) {
* IS TRUE predicate.
*/
private static LogicalExpression createIsTruePredicate(LogicalExpression
expr) {
- return new ParquetIsPredicate<Boolean>(expr,
+ return new ParquetIsPredicate<Boolean>(expr, (exprStat, evaluator) ->
//if max value is not true or if there are all nulls -> canDrop
- (exprStat, evaluator) -> !((BooleanStatistics)exprStat).getMax() ||
isAllNulls(exprStat, evaluator.getRowCount())
+ isAllNulls(exprStat, evaluator.getRowCount()) ||
exprStat.hasNonNullValue() && !((BooleanStatistics)exprStat).getMax()
Review comment:
Please add space after `(BooleanStatistics)` here in in three cases below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Minor code improvements in parquet statistics handling
> ------------------------------------------------------
>
> Key: DRILL-6554
> URL: https://issues.apache.org/jira/browse/DRILL-6554
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 1.14.0
>
>
> Avoid setting statistics in Metadata when min and max are not defined and few
> other minor code improvements.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
