[
https://issues.apache.org/jira/browse/DRILL-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527835#comment-16527835
]
ASF GitHub Bot commented on DRILL-6554:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1349: DRILL-6554: Minor
code improvements in parquet statistics handling
URL: https://github.com/apache/drill/pull/1349#discussion_r199197846
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java
##########
@@ -417,16 +417,9 @@ public static DateCorruptionStatus
checkForCorruptDateValuesInStatistics(Parquet
// column does not appear in this file, skip it
continue;
}
- Statistics statistics =
footer.getBlocks().get(rowGroupIndex).getColumns().get(colIndex).getStatistics();
- Integer max = (Integer) statistics.genericGetMax();
- if (statistics.hasNonNullValue()) {
- if (max > ParquetReaderUtility.DATE_CORRUPTION_THRESHOLD) {
- return DateCorruptionStatus.META_SHOWS_CORRUPTION;
- }
- } else {
- // no statistics, go check the first page
- return DateCorruptionStatus.META_UNCLEAR_TEST_VALUES;
- }
+ IntStatistics statistics =
(IntStatistics)footer.getBlocks().get(rowGroupIndex).getColumns().get(colIndex).getStatistics();
Review comment:
1. space after `(IntStatistics)`: `(IntStatistics) footer.getBlocks()...`
2. What if statistics is not int one? Maybe check for instanceOf?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Minor code improvements in parquet statistics handling
> ------------------------------------------------------
>
> Key: DRILL-6554
> URL: https://issues.apache.org/jira/browse/DRILL-6554
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 1.14.0
>
>
> Avoid setting statistics in Metadata when min and max are not defined and few
> other minor code improvements.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
