[
https://issues.apache.org/jira/browse/DRILL-6554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527883#comment-16527883
]
ASF GitHub Bot commented on DRILL-6554:
---------------------------------------
vrozov commented on a change in pull request #1349: DRILL-6554: Minor code
improvements in parquet statistics handling
URL: https://github.com/apache/drill/pull/1349#discussion_r199208654
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetPredicatesHelper.java
##########
@@ -39,22 +40,21 @@ static boolean isNullOrEmpty(Statistics stat) {
*
* @param stat parquet column statistics
* @param rowCount number of rows in the parquet file
- * @return True if all rows are null in the parquet file
- * False if at least one row is not null.
+ * @return <tt>true</tt> if all rows are null in the parquet file and
<tt>false</tt> otherwise
*/
static boolean isAllNulls(Statistics stat, long rowCount) {
- return stat.isNumNullsSet() && stat.getNumNulls() == rowCount;
+ Preconditions.checkArgument(rowCount >= 0, String.format("negative
rowCount %d is not valid", rowCount));
Review comment:
To validate input. It can't give the correct answer if an input is a junk
(`rowCount` is negative).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Minor code improvements in parquet statistics handling
> ------------------------------------------------------
>
> Key: DRILL-6554
> URL: https://issues.apache.org/jira/browse/DRILL-6554
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
> Fix For: 1.14.0
>
>
> Avoid setting statistics in Metadata when min and max are not defined and few
> other minor code improvements.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
