[
https://issues.apache.org/jira/browse/DRILL-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531886#comment-16531886
]
ASF GitHub Bot commented on DRILL-6578:
---------------------------------------
sachouche commented on issue #1360: DRILL-6578: Handle query cancellation in
Parquet reader
URL: https://github.com/apache/drill/pull/1360#issuecomment-402282723
@vrozov , sorry for the back & forth but I cannot read your mind because you
give very few details with your suggestions.
Sure I can handle the exception within the setSafe method; I only have one
shot at this because I will be OOO tonight and working on another JIRA; this is
the summary (please stop me if you don't agree):
a) move the static checkInterrupted() method into DrillRuntimeException
b) move the checks into the setSafe() method
c) setSafe will throw a DrillRuntimeException if the interrupt flag is set
d) use the Thread.interrupted() method to clear the flag after handling
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure the Flat Parquet Reader can handle query cancellation
> ------------------------------------------------------------
>
> Key: DRILL-6578
> URL: https://issues.apache.org/jira/browse/DRILL-6578
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> * The optimized Parquet reader uses an iterator style to load column data
> * We need to ensure the code can properly handle query cancellation even in
> the presence of bugs within the hasNext() .. next() calls
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
