[
https://issues.apache.org/jira/browse/DRILL-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531900#comment-16531900
]
ASF GitHub Bot commented on DRILL-6578:
---------------------------------------
vrozov commented on issue #1360: DRILL-6578: Handle query cancellation in
Parquet reader
URL: https://github.com/apache/drill/pull/1360#issuecomment-402286366
@sachouche I guess, you mean raise, not handle. For the rest
a) if you throw DrillRuntimeException, please see c)
b) yes (move it to a method that uses an iterator, if it is `setSafe()`,
then move it to that method)
c) I would prefer InterruptedException over DrillRuntimeException, but if it
is too much to propagate InterruptedException, I am OK with
DrillRuntimeException.
d) yes, when an exception is raised, the interrupt flag needs to be cleared
to avoid throwing exception again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure the Flat Parquet Reader can handle query cancellation
> ------------------------------------------------------------
>
> Key: DRILL-6578
> URL: https://issues.apache.org/jira/browse/DRILL-6578
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> * The optimized Parquet reader uses an iterator style to load column data
> * We need to ensure the code can properly handle query cancellation even in
> the presence of bugs within the hasNext() .. next() calls
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
