[
https://issues.apache.org/jira/browse/DRILL-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560466#comment-16560466
]
ASF GitHub Bot commented on DRILL-6616:
---------------------------------------
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205918553
##########
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcPrel.java
##########
@@ -130,4 +131,10 @@ public SelectionVectorMode getEncoding() {
public boolean needsFinalColumnReordering() {
return false;
}
+
+ @Override
+ public Prel addImplicitRowIDCol(List<RelNode> children) {
Review comment:
I am thinking a cleaner interface would be to have an additional method
`supportsImplicitRIDCol()` which would return FALSE by default. You could use
the Java 8 feature for default interface methods [1]. Only call
`addImplicitRowIdCol()` if adding the rowid is supported.
[1] https://dzone.com/articles/interface-default-methods-java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch Processing for Lateral/Unnest
> -----------------------------------
>
> Key: DRILL-6616
> URL: https://issues.apache.org/jira/browse/DRILL-6616
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement the execution and planner side changes for the batch processing
> done by lateral and unnest. Based on the prototype we found performance to be
> much better as compared to initial row-by-row execution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
