[
https://issues.apache.org/jira/browse/DRILL-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560462#comment-16560462
]
ASF GitHub Bot commented on DRILL-6616:
---------------------------------------
amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205915503
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/LateralJoinPOP.java
##########
@@ -38,6 +38,9 @@
@JsonProperty("excludedColumns")
private List<SchemaPath> excludedColumns;
+ @JsonProperty("implicitColumn")
+ private String implicitColumn;
Review comment:
It would be better to name it more precisely as implicitRIDColumn or
something similar here as well as other places where implicitColumn is used.
The reason is in theory there could be more than 1 implicit columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch Processing for Lateral/Unnest
> -----------------------------------
>
> Key: DRILL-6616
> URL: https://issues.apache.org/jira/browse/DRILL-6616
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement the execution and planner side changes for the batch processing
> done by lateral and unnest. Based on the prototype we found performance to be
> much better as compared to initial row-by-row execution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
