[
https://issues.apache.org/jira/browse/DRILL-6616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16562152#comment-16562152
]
ASF GitHub Bot commented on DRILL-6616:
---------------------------------------
HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r206249561
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java
##########
@@ -81,4 +86,17 @@ public boolean needsFinalColumnReordering() {
return true;
}
+ @Override
+ public Prel addImplicitRowIDCol(List<RelNode> children) {
+ RexBuilder builder = this.getCluster().getRexBuilder();
+ return (Prel) this.copy(this.traitSet, children.get(0),
DrillRelOptUtil.transformExpr(builder, condition, buildMap()));
+ }
+
+ private Map<Integer, Integer> buildMap() {
+ Map<Integer, Integer> map = new HashMap<>();
+ for (int i=0;i<this.getInput().getRowType().getFieldCount();i++) {
+ map.put(i, i+1);
Review comment:
Yes. I did consider this option but for aggregations calcite expects to
place the group by columns at the beginning of the row type. Hence, I thought
it is better to do this uniformly across all other operators as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Batch Processing for Lateral/Unnest
> -----------------------------------
>
> Key: DRILL-6616
> URL: https://issues.apache.org/jira/browse/DRILL-6616
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.14.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement the execution and planner side changes for the batch processing
> done by lateral and unnest. Based on the prototype we found performance to be
> much better as compared to initial row-by-row execution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
