[ 
https://issues.apache.org/jira/browse/DRILL-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908299#comment-16908299
 ] 

ASF GitHub Bot commented on DRILL-7350:
---------------------------------------

paul-rogers commented on pull request #1843: DRILL-7350: Move RowSet related 
classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314401892
 
 

 ##########
 File path: 
exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java
 ##########
 @@ -99,13 +99,6 @@ public DirectRowSet next() {
     }
   }
 
-  public void printAll() {
 
 Review comment:
   Please either leave this, or move it to a utility class. This turns out to 
be a very handy way to validate or debug a unit test: add a call while working 
on the test to visualize the results, remove the call when done.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Move RowSet related classes from test folder
> --------------------------------------------
>
>                 Key: DRILL-7350
>                 URL: https://issues.apache.org/jira/browse/DRILL-7350
>             Project: Apache Drill
>          Issue Type: Task
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>             Fix For: 1.17.0
>
>
> Move RowSet related classes from test folder to main to be able to use them 
> for Metastore.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to