[
https://issues.apache.org/jira/browse/DRILL-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955998#comment-16955998
]
ASF GitHub Bot commented on DRILL-7414:
---------------------------------------
arina-ielchiieva commented on pull request #1878: DRILL-7414: EVF incorrectly
sets buffer writer index after rollover
URL: https://github.com/apache/drill/pull/1878#discussion_r336972303
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderOverflow.java
##########
@@ -59,55 +61,64 @@
@Test
public void testVectorSizeLimit() {
- TupleMetadata schema = new SchemaBuilder()
+ final TupleMetadata schema = new SchemaBuilder()
Review comment:
Since Java supports effective final there is no need to excessive use of
final keyword unless you want to explicitly indicate that variable is final. I
am not going to request the change during code review, I guess this mostly
relates to the developers code writing style but since you are making lots of
refactoring adding final keyword, just wanted to highlight that this is might
be unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> EVF incorrectly sets buffer writer index after rollover
> -------------------------------------------------------
>
> Key: DRILL-7414
> URL: https://issues.apache.org/jira/browse/DRILL-7414
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.17.0
>
>
> A full test run, with vector validation enabled and with the "new" scan
> enabled, revealed the following in {{TestMockPlugin.testSizeLimit()}}:
> {noformat}
> comments_s20000 - VarCharVector: Row count = 838, but value count = 839
> {noformat}
> Adding vector validation to the result set loader overflow tests reveals that
> the problem is in overflow. In
> {{TestResultSetLoaderOverflow.testOverflowWithNullables()}}:
> {noformat}
> a - RepeatedIntVector: Row count = 2952, but value count = 2953
> b - RepeatedVarCharVector: Row count = 2952, but value count = 2953
> b - RepeatedVarCharVector: Vector has 2953 values, but offset vector labels
> 32472 values
> c - RepeatedIntVector: Row count = 2952, but value count = 2953
> d - RepeatedIntVector: Row count = 2952, but value count = 2953
> {noformat}
> The problem is that EVF incorrectly sets the offset buffer writer index after
> a rollover.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
