[
https://issues.apache.org/jira/browse/DRILL-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956646#comment-16956646
]
ASF GitHub Bot commented on DRILL-7414:
---------------------------------------
paul-rogers commented on pull request #1878: DRILL-7414: EVF incorrectly sets
buffer writer index after rollover
URL: https://github.com/apache/drill/pull/1878#discussion_r337311938
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderOverflow.java
##########
@@ -59,55 +61,64 @@
@Test
public void testVectorSizeLimit() {
- TupleMetadata schema = new SchemaBuilder()
+ final TupleMetadata schema = new SchemaBuilder()
Review comment:
Sorry, too much functional programming with Scala in my "real job"; have
gotten used to marking variables 'val` rather than `var`. `final` is the Java
equivalent. But, since Drill does not normally use this convention, removed the
unneeded `final` keywords.
You are right; if there is a performance benefit, the compiler will figure
out that the variable is never modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> EVF incorrectly sets buffer writer index after rollover
> -------------------------------------------------------
>
> Key: DRILL-7414
> URL: https://issues.apache.org/jira/browse/DRILL-7414
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.17.0
>
>
> A full test run, with vector validation enabled and with the "new" scan
> enabled, revealed the following in {{TestMockPlugin.testSizeLimit()}}:
> {noformat}
> comments_s20000 - VarCharVector: Row count = 838, but value count = 839
> {noformat}
> Adding vector validation to the result set loader overflow tests reveals that
> the problem is in overflow. In
> {{TestResultSetLoaderOverflow.testOverflowWithNullables()}}:
> {noformat}
> a - RepeatedIntVector: Row count = 2952, but value count = 2953
> b - RepeatedVarCharVector: Row count = 2952, but value count = 2953
> b - RepeatedVarCharVector: Vector has 2953 values, but offset vector labels
> 32472 values
> c - RepeatedIntVector: Row count = 2952, but value count = 2953
> d - RepeatedIntVector: Row count = 2952, but value count = 2953
> {noformat}
> The problem is that EVF incorrectly sets the offset buffer writer index after
> a rollover.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
