[
https://issues.apache.org/jira/browse/DRILL-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956647#comment-16956647
]
ASF GitHub Bot commented on DRILL-7414:
---------------------------------------
paul-rogers commented on pull request #1878: DRILL-7414: EVF incorrectly sets
buffer writer index after rollover
URL: https://github.com/apache/drill/pull/1878#discussion_r337312721
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/OffsetVectorWriterImpl.java
##########
@@ -290,7 +290,7 @@ public void preRollover() {
// rows. But, this being an offset vector, we add one to account
// for the extra 0 value at the start.
- setValueCount(vectorIndex.rowStartIndex() + 1);
+ setValueCount(vectorIndex.rowStartIndex());
Review comment:
Updated the comment as it was too subtle. The row start index is already at
the proper index, it points past the last valid value (it points to where we'd
add the next value, if we had one.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> EVF incorrectly sets buffer writer index after rollover
> -------------------------------------------------------
>
> Key: DRILL-7414
> URL: https://issues.apache.org/jira/browse/DRILL-7414
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.17.0
>
>
> A full test run, with vector validation enabled and with the "new" scan
> enabled, revealed the following in {{TestMockPlugin.testSizeLimit()}}:
> {noformat}
> comments_s20000 - VarCharVector: Row count = 838, but value count = 839
> {noformat}
> Adding vector validation to the result set loader overflow tests reveals that
> the problem is in overflow. In
> {{TestResultSetLoaderOverflow.testOverflowWithNullables()}}:
> {noformat}
> a - RepeatedIntVector: Row count = 2952, but value count = 2953
> b - RepeatedVarCharVector: Row count = 2952, but value count = 2953
> b - RepeatedVarCharVector: Vector has 2953 values, but offset vector labels
> 32472 values
> c - RepeatedIntVector: Row count = 2952, but value count = 2953
> d - RepeatedIntVector: Row count = 2952, but value count = 2953
> {noformat}
> The problem is that EVF incorrectly sets the offset buffer writer index after
> a rollover.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
