[
https://issues.apache.org/jira/browse/DRILL-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995060#comment-16995060
]
ASF GitHub Bot commented on DRILL-7479:
---------------------------------------
paul-rogers commented on issue #1923: DRILL-7479: Partial fixes for metadata
parameterized type issues
URL: https://github.com/apache/drill/pull/1923#issuecomment-565176282
Tried to clean up a few more warnings. Have found even more cases where we
want to assign types statically, but work with them generically at runtime. Had
to add some horrible hacks to cast away the (unknown) type.
Also, found another issue in `FilterExpression.Visitor`. The predicates are
parameterized, but untyped in the visitor class. Typing them causes many tests
to fail. So, we've got a case where we *must* abuse the Java type system to get
the code to work. That is a strong "code smell" that some adjusting wants to be
done.
The one issue I can see is that some of the proposed changes will change the
serialized metadata format. If anyone starts to use the features from this
release, some form of upgrade will be needed when that user upgrades. This
incompatibility could be a reason to fix the issues now rather than later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Short-term fixes for metadata API parameterized type issues
> -----------------------------------------------------------
>
> Key: DRILL-7479
> URL: https://issues.apache.org/jira/browse/DRILL-7479
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Blocker
> Labels: ready-to-commit
> Fix For: 1.17.0
>
>
> See DRILL-7480 for a discussion of the issues with how we currently use
> parameterized types in the metadata API.
> This ticket is for short-term fixes that convert unsafe generic types of the
> form {{StatisticsHolder}} to the form {{StatisticsHolder<?>}} so that the
> compiler does not complain with many warnings (and a few Eclipse-only errors.)
> The topic should be revisited later in the context of DRILL-7480.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
