[
https://issues.apache.org/jira/browse/DRILL-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995697#comment-16995697
]
ASF GitHub Bot commented on DRILL-7479:
---------------------------------------
vvysotskyi commented on pull request #1923: DRILL-7479: Partial fixes for
metadata parameterized type issues
URL: https://github.com/apache/drill/pull/1923#discussion_r357692806
##########
File path:
metastore/metastore-api/src/main/java/org/apache/drill/metastore/components/tables/BasicTablesTransformer.java
##########
@@ -99,6 +99,9 @@ public static MetadataHolder all(List<TableMetadataUnit>
units) {
case PARTITION:
partitions.add(PartitionMetadata.builder().metadataUnit(unit).build());
break;
+ default:
+ // Throw an error?
Review comment:
Please either throw an error here or remove this comment. But it is
impossible to obtain a non-listed type here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Short-term fixes for metadata API parameterized type issues
> -----------------------------------------------------------
>
> Key: DRILL-7479
> URL: https://issues.apache.org/jira/browse/DRILL-7479
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Blocker
> Labels: ready-to-commit
> Fix For: 1.17.0
>
>
> See DRILL-7480 for a discussion of the issues with how we currently use
> parameterized types in the metadata API.
> This ticket is for short-term fixes that convert unsafe generic types of the
> form {{StatisticsHolder}} to the form {{StatisticsHolder<?>}} so that the
> compiler does not complain with many warnings (and a few Eclipse-only errors.)
> The topic should be revisited later in the context of DRILL-7480.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
