[
https://issues.apache.org/jira/browse/DRILL-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057714#comment-17057714
]
ASF GitHub Bot commented on DRILL-7620:
---------------------------------------
arina-ielchiieva commented on pull request #2010: DRILL-7620: Fix plugin
mutability issues
URL: https://github.com/apache/drill/pull/2010#discussion_r391471772
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java
##########
@@ -96,6 +96,23 @@ public PluginEncodingException(String msg, Exception e) {
*/
void validatedPut(String name, StoragePluginConfig config) throws
PluginException;
+ /**
+ * Set the plugin to the requested enabled state. Does nothing if the plugin
+ * is already in the requested state. If a formerly enabled plugin is
+ * disabled, moves the plugin from the in-memory cache to the ephemeral
+ * store. If a formerly disabled plugin is enabled, verifies that the plugin
+ * can be instantiated as for {@link #verifiedPut()}.
+ * <p>
+ * Use this method when changing state. Do not obtain the config and change
+ * the state directly, doing so will make the plugin config inconsistent
+ * with the internal state.
+ *
+ * @param name name of the plugin
+ * @param enabled {@code true} to enable the plugin, {@code false} to disable
+ * @throws PluginNotFoundException it the plugin name is not valid
Review comment:
Can't this exception be thrown is plugin is missing? Why only invalid name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Storage plugin update page shows that a plugin is disabled though it is
> actually enabled.
> -----------------------------------------------------------------------------------------
>
> Key: DRILL-7620
> URL: https://issues.apache.org/jira/browse/DRILL-7620
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.18.0
> Reporter: Anton Gozhiy
> Assignee: Paul Rogers
> Priority: Blocker
> Fix For: 1.18.0
>
>
> *Steps to reproduce:*
> # On Web UI, open storage page
> # Disable some plugin (e.g. "cp")
> # Enable this plugin (It is displayed in "enabled" section now)
> # Update the plugin, look at the "enabled" property
> *Expected result:*
> "enabled": true
> *Actual result:*
> "enabled": false
> *Note:* Though it is displayed as disabled in the config, queries to it are
> working.
> *Workaround:* Enable it again.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
