[
https://issues.apache.org/jira/browse/DRILL-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361112#comment-17361112
]
ASF GitHub Bot commented on DRILL-7951:
---------------------------------------
jfmario commented on pull request #2256:
URL: https://github.com/apache/drill/pull/2256#issuecomment-858812676
@cgivre I think a lot of this looks good. I noticed that when I query an API
and receive a 404 response with no body, Drill throws an error instead of
giving me those fields.
I think there may be cases where that is preferred, but my view is that a
404 with no body is an informative response and not an error, so I would have
preferred to see the "fact of" the 400 response in the returning table. The
same thing applies to other 400 errors.
This may be something that users want to configure. I think 500s are always
errors, but if you add a configuration it may be worth letting users specify
which status codes should be treated as errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Response Metadata Fields to HTTP Storage Plugin
> ---------------------------------------------------
>
> Key: DRILL-7951
> URL: https://issues.apache.org/jira/browse/DRILL-7951
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: Future
>
>
> In many http calls, the response code can contain meaningful information,
> however these fields are not available unless the call results in an error.
> This PR adds four implicit metadata fields to the HTTP storage plugin which
> are:
> * _response_code: The HTTP response code. This field is returned as an INT.
>
> * _resposne_message: The response message.
> * _response_protocol: The response protocol.
> * _response_url: The actual URL that is sent to the API.
> As these are implicit fields, they will not appear in star queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
