[
https://issues.apache.org/jira/browse/DRILL-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370243#comment-17370243
]
ASF GitHub Bot commented on DRILL-7951:
---------------------------------------
cgivre commented on a change in pull request #2256:
URL: https://github.com/apache/drill/pull/2256#discussion_r659337823
##########
File path:
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/util/SimpleHttp.java
##########
@@ -171,6 +175,12 @@ public InputStream getInputStream() {
.newCall(request)
.execute();
+ // Preserve the response
+ responseMessage = response.message();
+ responseCode = response.code();
+ responseProtocol = response.protocol().toString();
+ responseURL = response.request().url().toString();
Review comment:
I'm fairly certain that by definition these fields will be populated.
For instance, in order to get a response, you have to send data to a URL, hence
that URL will be defined in the response. I added a null check and the IDE
complained and confirmed that `protocol` and the `url` field will never be
null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Response Metadata Fields to HTTP Storage Plugin
> ---------------------------------------------------
>
> Key: DRILL-7951
> URL: https://issues.apache.org/jira/browse/DRILL-7951
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: Future
>
>
> In many http calls, the response code can contain meaningful information,
> however these fields are not available unless the call results in an error.
> This PR adds four implicit metadata fields to the HTTP storage plugin which
> are:
> * _response_code: The HTTP response code. This field is returned as an INT.
>
> * _resposne_message: The response message.
> * _response_protocol: The response protocol.
> * _response_url: The actual URL that is sent to the API.
> As these are implicit fields, they will not appear in star queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
