[
https://issues.apache.org/jira/browse/DRILL-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17370234#comment-17370234
]
ASF GitHub Bot commented on DRILL-7951:
---------------------------------------
cgivre commented on a change in pull request #2256:
URL: https://github.com/apache/drill/pull/2256#discussion_r659332606
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ImplicitColumnUtils.java
##########
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.drill.exec.store;
+
+import org.apache.drill.common.types.TypeProtos.DataMode;
+import org.apache.drill.common.types.TypeProtos.MinorType;
+import org.apache.drill.exec.physical.resultSet.RowSetLoader;
+import org.apache.drill.exec.record.metadata.ColumnMetadata;
+import org.apache.drill.exec.record.metadata.MetadataUtils;
+import org.apache.drill.exec.vector.accessor.ScalarWriter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class ImplicitColumnUtils {
+ private static final Logger logger =
LoggerFactory.getLogger(ImplicitColumnUtils.class);
+
+ public static class ImplicitColumns {
+ private final Map<String, ImplicitColumn> implicitColumns;
+ private final RowSetLoader rowWriter;
+
+ public ImplicitColumns (RowSetLoader rowWriter) {
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Add Response Metadata Fields to HTTP Storage Plugin
> ---------------------------------------------------
>
> Key: DRILL-7951
> URL: https://issues.apache.org/jira/browse/DRILL-7951
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Other
> Affects Versions: 1.19.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: Future
>
>
> In many http calls, the response code can contain meaningful information,
> however these fields are not available unless the call results in an error.
> This PR adds four implicit metadata fields to the HTTP storage plugin which
> are:
> * _response_code: The HTTP response code. This field is returned as an INT.
>
> * _resposne_message: The response message.
> * _response_protocol: The response protocol.
> * _response_url: The actual URL that is sent to the API.
> As these are implicit fields, they will not appear in star queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
