847850277 commented on PR #4340: URL: https://github.com/apache/eventmesh/pull/4340#issuecomment-1669170192
> You misunderstand me, the 2 `fixed` commits made unsuitable changes. Maybe you could take a look at `org.apache.eventmesh.admin.rocketmq.util.UrlMappingPatternTest` for some inspiration. 😊 I have looked at the test example of `UrlMappingPatternTest`, and I believe that the current test case is also verifying whether the actual and expected values before and after the change are the same, and that each test case is used to verify its correctness. In fact, the purpose he achieved in `UrlMappingPatternTest` is the same.😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
