pandaapo commented on PR #4340: URL: https://github.com/apache/eventmesh/pull/4340#issuecomment-1669232865
> The problem lies on the `testBuilder()`. > >  > > To test `builder().build()`, please use `assertEquals` to verify the expected `WebhookProtocolTransportObject` and actual `WebhookProtocolTransportObject` are same. This leads to a self-verification situation. `[fdce71e](https://github.com/apache/eventmesh/pull/4340/commits/fdce71e06a87f3387cbbde920e59f092be67843d)` looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
