Pil0tXia commented on PR #4340: URL: https://github.com/apache/eventmesh/pull/4340#issuecomment-1669324642
>I think it is unnecessary to verify the functionality of lombok in such a way in evntmesh. It should belong to lombok's work. I agree, this is merely an entity class, with no logic to be tested. However, when it comes to self-validation situation, most unit tests without Mockito are essentially self-validation. For this data class, since the logic is overly simplistic, this issue is particularly pronounced. In simple terms, testing setters and builders is just redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
