Pil0tXia commented on code in PR #4477:
URL: https://github.com/apache/eventmesh/pull/4477#discussion_r1351205810
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/enums/EventMeshMessageProtocolType.java:
##########
@@ -17,24 +17,24 @@
package org.apache.eventmesh.common.enums;
-public enum EventMeshProtocolType {
+public enum EventMeshMessageProtocolType {
CLOUD_EVENTS("cloudevents"),
EVENT_MESH_MESSAGE("eventmeshmessage"),
OPEN_MESSAGE("openmessage");
Review Comment:
`EventMeshMessageProtocolType` class name is duplicate with its member
`EVENT_MESH_MESSAGE("eventmeshmessage")`. It's better to rename to
`MessageProtocolType` if no more conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
