Pil0tXia commented on code in PR #4477:
URL: https://github.com/apache/eventmesh/pull/4477#discussion_r1351765003
##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/EventMeshGrpcConsumer.java:
##########
@@ -128,8 +129,9 @@ public void subscribe(final List<SubscriptionItem>
subscriptionItems) {
addSubscription(subscriptionItems, SDK_STREAM_URL);
- CloudEvent subscription =
EventMeshCloudEventBuilder.buildEventSubscription(clientConfig,
EventMeshProtocolType.EVENT_MESH_MESSAGE, null,
- subscriptionItems);
+ CloudEvent subscription =
+ EventMeshCloudEventBuilder.buildEventSubscription(clientConfig,
EventMeshMessageProtocolType.EVENT_MESH_MESSAGE, null,
+ subscriptionItems);
synchronized (this) {
Review Comment:
The former one seems confusing and the later one will be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
