pandaapo commented on code in PR #4477: URL: https://github.com/apache/eventmesh/pull/4477#discussion_r1352051495
########## eventmesh-connectors/eventmesh-connector-spring/src/main/java/org/apache/eventmesh/connector/spring/source/MessageSendingOperations.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.connector.spring.source; + +import org.apache.eventmesh.common.enums.ProtocolType; + +/** + * Operations for sending messages to a destination. + */ +public interface MessageSendingOperations { Review Comment: I am still confused about the Source you have implemented. You start the Source Connector Server by launching it through the Spring container, but after your Source is started, the `queue` of `SpringSourceConnector` is always empty, and I didn't see any behavior of obtaining data from a source in any form. Could you explain it? --- 我对你实现的Source仍然有困惑。你通过Spring容器启动来启动Source Connector Server,但是你的Source启动完成后,`SpringSourceConnector`的`queue`一直是空的,我好像没看到从某个源以某种形式获取数据的行为。你能否解答一下? ########## eventmesh-connectors/eventmesh-connector-spring/src/main/java/org/apache/eventmesh/connector/spring/source/MessageSendingOperations.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.connector.spring.source; + +import org.apache.eventmesh.common.enums.ProtocolType; + +/** + * Operations for sending messages to a destination. + */ +public interface MessageSendingOperations { Review Comment: I am still confused about the Source you have implemented. You start the Source Connector Server by launching it through the Spring container, but after your Source is started, the `queue` of `SpringSourceConnector` is always empty, and I didn't see any behavior of obtaining data from a source in any form. Could you explain it? --- 我对你实现的Source仍然有困惑。你通过Spring容器启动来启动Source Connector Server,但是你的Source启动完成后,`SpringSourceConnector`的`queue`一直是空的,我好像没看到从某个源以某种形式获取数据的行为。你能否解答一下? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
